experimental: Ranges animation control #5125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft

istarkov wants to merge 2 commits into main from ranges

Member

istarkov commented Apr 14, 2025 •

edited

Loading

Description

https://6382151c8b47d4399fb9fc69-mgmubxoyek.chromatic.com/?path=/story/builder-components-animationranges--basic

Steps for reproduction

click button
expect xyz

Code Review

hi @kof, I need you to do
- conceptual review (architecture, feature-correctness)
- detailed review (read every line)
- test it on preview

Before requesting a review

made a self-review
added inline comments where things may be not obvious (the "why", not "what")

Before merging

tested locally and on preview environment (preview dev login: 0000)
updated test cases document
added tests
if any new env variables are added, added them to .env file


          experimental: Ranges animation control

73b275e

Add border animation

Move vars

Try ranges

istarkov force-pushed the ranges branch from 13b8403 to 73b275e Compare

April 16, 2025 11:24


          Fix inset

f2a9900

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet