Enhancement/push filter down AppendVertices #5490
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czpmango
force-pushed
the
enhancement/PushFilterDownAppendVertices
branch
from
39a1885 to
8bf34ae
Compare
czpmango
force-pushed
the
enhancement/PushFilterDownAppendVertices
branch
5 times, most recently
from
e0d12ae to
6b3083e
Compare
czpmango
added
ready for review
auto-sync
ready-for-testing
czpmango
force-pushed
the
enhancement/PushFilterDownAppendVertices
branch
from
36f543f to
2069a2d
Compare
Add tck small change fix tck fix tck Fix tck flush vscode ... small fix Fix tck
czpmango
force-pushed
the
enhancement/PushFilterDownAppendVertices
branch
from
3a0bc58 to
e22e6c7
Compare
jievince
previously approved these changes
Apr 17, 2023
xtcyclist
reviewed
Apr 17, 2023
| auto pool = qctx->objPool(); | ||
| auto condition = graph::ExpressionUtils::rewriteVertexPropertyFilter( | ||
| pool, appendVertices->colNames().back(), filter->condition()->clone()); | ||
|
|
Contributor
There was a problem hiding this comment.
Need to port the latest version of this file from the ent repo. I introduced a bug fix here at line:48.
xtcyclist
reviewed
Apr 17, 2023
| | 1 | PassThrough | 3 | | | ||
| | 3 | Start | | | | ||
|
|
||
| # FIXME(czp): Disable this for now. The ngdata test set lacks validation mechanisms |
Contributor
There was a problem hiding this comment.
Why disable this test? At least we need to check the code, if these queries produced different results. Did you encounter a different result here? Being different itself is a potential problem.
We need to have complex datasets like ngdata in the CI. It's necessary. Validation could be improved later.
xtcyclist
reviewed
Apr 17, 2023
| # | id | name | dependencies | operator info | | ||
| # | 9 | Aggregate | 11 | | | ||
| # | 11 | Project | 10 | | | ||
| # | 10 | Filter | 6 | | |
Contributor
There was a problem hiding this comment.
This filter was gone in the ent version, after pushing the filter down into appendvertices, hence there is such a tck case here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Fix #5492
Fix https://github.com/vesoft-inc/nebula-ent/issues/2604
Description:
Just move the optimizer rule from ent version.
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects: