Skip to content

websocket: Limit post-decompression size of received messages #2391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2018
Merged

websocket: Limit post-decompression size of received messages #2391

merged 1 commit into from
May 19, 2018

Conversation

bdarnell
Copy link
Member

Protects against memory exhaustion DoS attacks.

@bdarnell
websocket: Limit post-decompression size of received messages
7bd3ef3 
Protects against memory exhaustion DoS attacks.
@bdarnell bdarnell force-pushed the websocket-decompress-limit branch from 56053c6 to 7bd3ef3 Compare May 19, 2018 15:34
@bdarnell bdarnell merged commit 729f1d9 into tornadoweb:master May 19, 2018
@bdarnell bdarnell deleted the websocket-decompress-limit branch May 19, 2018 23:10
@aaugustin aaugustin mentioned this pull request May 20, 2018
Merged
@spaceone
Copy link
Contributor

Is this exploitable even when one doesn't use websockets? E.g. in a standard tonado set up which serves some hello world html app?

@ploxiln
Copy link
Contributor

ploxiln commented Mar 25, 2020

Yes, I think standard http Content-Encoding: gzip has long been handled with a maximum decompress output size:
https://github.com/tornadoweb/tornado/blob/v6.0.4/tornado/http1connection.py#L730-L732

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdarnell @spaceone @ploxiln