fix/typo:makeESPFirmwareImage#5028
Merged
deadprogram merged 1 commit intotinygo-org:devfrom Sep 12, 2025
Merged
Conversation
eliasnaur
approved these changes
Sep 8, 2025
Contributor
Author
|
and i submit another for current macos ci fail #5030 |
aykevl
approved these changes
Sep 9, 2025
Member
aykevl
left a comment
aykevl
left a comment
There was a problem hiding this comment.
Heh, probably my typo originally. Thanks for spotting/fixing!
Contributor
Author
luoliwoshang
force-pushed
the
fix/type
branch
from
4a79d86 to
d029c2a
Compare
Member
|
@luoliwoshang please note that I changed the branch for this PR to https://tinygo.org/docs/guides/contributing/#how-to-use-our-github-repository |
Contributor
Author
Got it! I accidentally forgot about this matter, I'm very sorry. |
Contributor
Author
|
seems timeout |
Member
|
Thanks for the correction @luoliwoshang and to @aykevl for review. Now merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FirmareImage -> FirmwareImage