Skip to content

Conversation

y-hsgw
Copy link
Member

@y-hsgw y-hsgw commented Sep 2, 2025

Checks

Changes

  • Added a test case to reproduce and validate a known false positive in the no-node-access rule.
    (It may be easier to review with Hide whitespace enabled.)

Context

Fixes: #1066 , #1065

Copy link

codecov bot commented Sep 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.41%. Comparing base (bf4871f) to head (0c41bc0).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1073   +/-   ##
=======================================
  Coverage   96.40%   96.41%           
=======================================
  Files          50       50           
  Lines        2674     2675    +1     
  Branches     1100     1100           
=======================================
+ Hits         2578     2579    +1     
  Misses         96       96           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@y-hsgw y-hsgw linked an issue Sep 2, 2025 that may be closed by this pull request
@Belco90 Belco90 self-requested a review September 2, 2025 14:54
@Belco90 Belco90 merged commit ab45896 into testing-library:main Sep 2, 2025
31 checks passed
@y-hsgw y-hsgw deleted the test/no-node-access branch September 2, 2025 14:56
Copy link

github-actions bot commented Sep 3, 2025

🎉 This PR is included in version 7.6.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no-node-access false positive when passing element to a function no-node-access false-positive on WordPress "select" function
2 participants