Fix regenerate xml #863
Open
Fix regenerate xml #863
+19
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@weaverryan can you check this? |
weaverryan
reviewed
May 5, 2021
There was a problem hiding this comment.
Thanks for the PR @jhonaikerf and sorry for the slow review. Mostly, we need some tests that show what you're fixing with these changes.
Thanks!
|
|
||
| if (\in_array($fieldName, $traitProperties) || isset($mapping['declared'])) { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
Can you explain this a bit? And we'll need a test case that shows what this is fixing :)
| $loaded = $this->isInstanceOf($cmf, AbstractClassMetadataFactory::class) ? $cmf->getLoadedMetadata() : []; | ||
| } | ||
|
|
||
| foreach ($loaded as $m) { |
There was a problem hiding this comment.
Can you include the test case from #579 so we can see that it's passing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#207
#579