Remove dupliacte include of linux-yocto-virtualization.inc #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Including linux-yocto-virtualization.inc in the linix-yocto recipes is not needed as it is pulled in for both linux-yocto-5.x and linux-yocto-dev from the meta-virtualization recipes. Before removing this, there were a number of "WARNING: Duplicate inclusion for ..." warnings in the build. Signed-off-by: Matt Spencer <matthew@thespencers.me.uk>
Contributor
|
@m5p3nc3r yes, you're correct, this is duplicate. Sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including linux-yocto-virtualization.inc in the linix-yocto recipes is not needed as it is pulled in for both linux-yocto-5.x and
linux-yocto-dev from the meta-virtualization recipes.
Before removing this, there were a number of "WARNING: Duplicate inclusion for ..." warnings in the build.
@khilman I know you committed this in an earlier patch set, can you review that you are happy with this?
I have tested using both linux-yocto-5.4 and linux-yocto-5.8 (from the master Poky branch) and docker works fine for me. I have not tested on linux-yocto-dev, but from code inspection I believe it should work fine.