Fix model booting #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laravel looks for a method named `boot<TraitName>` so that traits can boot while still allowing the model itself to have a `boot()` method. [More info can be found here.](https://www.archybold.com/blog/post/booting-eloquent-model-traits)
Owner
|
Thanks for this PR |
Contributor
Author
|
My pleasure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Laravel looks for a method named
boot<TraitName>so that traits can boot while still allowing the model itself to have aboot()method. More info can be found here.This PR simply changes the
boot()method name tobootDefaultOrderBy()so that it doesn't collide with existing modelboot()methods. It also prevents an error when$orderByColumnisn't defined (it just returns, doing nothing)I put the releases in the changelog too ;)
Thanks!