ENH: update html parameter display to match scikit-learn style#504
Draft
AnimeshPatra2005 wants to merge 2 commits intosktime:mainfrom
Draft
ENH: update html parameter display to match scikit-learn style#504AnimeshPatra2005 wants to merge 2 commits intosktime:mainfrom
AnimeshPatra2005 wants to merge 2 commits intosktime:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Closes #503. Related to sktime/sktime#9497.
What does this implement/fix? Explain your changes.
scikit-learn has updated how they display parameters in the HTML representation of estimators. This PR updates scikit-base to match.
Previously, clicking an estimator box in a Jupyter notebook showed a raw
<pre>string likeMyEstimator(alpha=0.5).This PR replaces that with a structured two-column parameter table built from
get_params(deep=False), showing each parameter name and its current value in a cleaner, more readable format.Changes:
Does your contribution introduce a new dependency? If yes, which one?
No.
What should a reviewer concentrate their feedback on?
<pre>for non-estimator objects is correctAny other comments?
Marked as Draft, happy to add unit tests once the approach is confirmed as the right direction.