Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: serkanyersen/ifvisible.js
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: serkanyersen/ifvisible.js
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: feat/modernize-build-tooling
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 16 files changed
  • 1 contributor

Commits on May 21, 2025

  1. feat: Modernize build tooling and TypeScript 

    I've updated the project to use modern versions of key development dependencies and refined configurations accordingly.

Key changes include:

- TypeScript updated to v5.x.
- Webpack updated to v5.x, webpack-cli to v6.x.
- ESLint updated to v8.x, with related plugins (@typescript-eslint/*, eslint-config-airbnb-typescript, eslint-plugin-import) updated to compatible versions.
- Jest updated to v29.x.
- ts-loader and ts-jest updated to versions compatible with new TypeScript, Webpack, and Jest.
- Replaced `webpack-shell-plugin` with `webpack-shell-plugin-next` for Webpack 5 compatibility.

Configuration Adjustments:
- `tsconfig.json`: Added `esModuleInterop: true`, `skipLibCheck: true`, and switched from `files` to `include` for better file management.
- `.eslintrc.js`: Added `import` to plugins, removed deprecated rules, and resolved rule conflicts (e.g., `space-before-function-paren`).
- `webpack.config.js`: Removed obsolete `--production` flag from build script and `AggressiveMergingPlugin`. Updated for `webpack-shell-plugin-next`.
- `package.json`:
    - Added `engines: { "node": ">=18.0.0" }`.
    - Added `scripts.test: "jest"`.
    - Updated `jest.transform` path for `ts-jest`.

Code Refinements:
- Applied stricter types in `src/**/*.ts` where feasible.
- Used `window.` prefix for timer functions (`setTimeout`, `setInterval`, etc.) for type consistency.
- Handled browser-specific properties and type inconsistencies with type assertions or more flexible types where necessary.

Build, lint, and all tests pass successfully with these changes.
Documentation (`README.md`) updated with a new "Development" section detailing the modernized setup and prerequisites.
    @google-labs-jules
    google-labs-jules[bot] committed May 21, 2025
    Configuration menu
    Copy the full SHA
    a2c3036 View commit details
    Browse the repository at this point in the history
Loading