Skip to content

Commit b974e93

Browse files
committed
fix(secrets): remove secret from vault when access key deleted
1 parent 84d9a73 commit b974e93

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

cli/cmd/root.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ func runService() {
8080
store,
8181
encryptionService,
8282
)
83-
accessKeyService := server.NewAccessKeyService(store, encryptionService)
83+
accessKeyService := server.NewAccessKeyService(store, encryptionService, store)
8484
secretStorageService := server.NewSecretStorageService(store, accessKeyService)
8585

8686
taskPool := tasks.CreateTaskPool(

services/server/access_key_svc.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,18 +10,20 @@ type AccessKeyService interface {
1010
}
1111

1212
type AccessKeyServiceImpl struct {
13-
accessKeyRepo db.AccessKeyManager
14-
encryptionService AccessKeyEncryptionService
15-
secretStorageService SecretStorageService
13+
accessKeyRepo db.AccessKeyManager
14+
encryptionService AccessKeyEncryptionService
15+
secretStorageRepo db.SecretStorageRepository
1616
}
1717

1818
func NewAccessKeyService(
1919
accessKeyRepo db.AccessKeyManager,
2020
encryptionService AccessKeyEncryptionService,
21+
secretStorageRepo db.SecretStorageRepository,
2122
) AccessKeyService {
2223
return &AccessKeyServiceImpl{
2324
accessKeyRepo: accessKeyRepo,
2425
encryptionService: encryptionService,
26+
secretStorageRepo: secretStorageRepo,
2527
}
2628
}
2729

@@ -33,7 +35,7 @@ func (s *AccessKeyServiceImpl) Delete(projectID int, keyID int) (err error) {
3335

3436
if key.SourceStorageID != nil {
3537
var storage db.SecretStorage
36-
storage, err = s.secretStorageService.GetSecretStorage(projectID, *key.SourceStorageID)
38+
storage, err = s.secretStorageRepo.GetSecretStorage(projectID, *key.SourceStorageID)
3739
if err != nil {
3840
return
3941
}

0 commit comments

Comments
 (0)