This repository was archived by the owner on Nov 24, 2018. It is now read-only.
feat: add support to ignore certificate errors#464
Open
skiloop wants to merge 2 commits intoschickling:masterfrom
Open
feat: add support to ignore certificate errors#464skiloop wants to merge 2 commits intoschickling:masterfrom
skiloop wants to merge 2 commits intoschickling:masterfrom
Conversation
Contributor
skiloop
commented
Aug 21, 2018
- new feature to add support to ignore certificate errors Allow interaction with sites having invalid SSL/TLS certificate #329
- Make sure all of the significant new logic is covered by tests
- Rebase your changes on master so that they can be merged easily
- Make sure all tests and linter rules pass
- If you've changed APIs, update the documentation in README and /api/README
Codecov Report
@@ Coverage Diff @@
## master #464 +/- ##
==========================================
- Coverage 39.01% 38.97% -0.04%
==========================================
Files 7 7
Lines 874 880 +6
Branches 126 127 +1
==========================================
+ Hits 341 343 +2
- Misses 533 537 +4
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.