a+=b vs a=a+b : clarify the difference is not universal #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made the text say it depends on class, and rest of explanation talk of lists, not objects.
satwikkansal
reviewed
Sep 6, 2017
README.md
Outdated
| #### 💡 Explanation: | ||
|
|
||
| * a += b doesn't behave the same way as a = a + b | ||
| * `a += b` doesn't always behave the same way as `a = a + b`. Classes *may* implement the op= operators differently, and lists do this. |
Owner
There was a problem hiding this comment.
@cben Thanks for the PR. Nice catch! Just a minor question, shouldn't "op=" be syntax highlighted as op=, or at least it'd be better to wrap it around quotes, I feel.
Contributor
Author
There was a problem hiding this comment.
done. op= is not actual syntax but discovered I can make op= italic, now I'm happy :-)
Owner
|
Thanks! Merged 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the text say it depends on class, and rest of explanation talk of lists, not objects.