fix: implement io.ReaderFrom in wrapped response#17
Merged
samber merged 1 commit intosamber:mainfrom Feb 2, 2026
Merged
Conversation
Owner
|
LGTM 👍 |
RSWilli
reviewed
Feb 3, 2026
| return n, err | ||
| } | ||
| } | ||
| return io.Copy(w, r) |
There was a problem hiding this comment.
@samber this line creates a stackoverflow on the new release from yesterday. Since w implements io.ReaderFrom now, io.Copy will call ReadFrom to perform the copying. This creates a stackoverflow on the first write.
The fix would be to call io.Copy(w.ResponseWriter, r) (or similar) instead.
I can create an issue for this if needed.
Contributor
Author
There was a problem hiding this comment.
Sorry, I missed testing the case with body != nil.
Using io.Copy(w.ResponseWriter, r) will not write to the body, so we need to find another way to not use ReadFrom in io.Copy.
I can have a look at it and also add a test to make sure both cases work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For compatibility with other middlewares (e.g. chi) that would otherwise skip a Hijacker interface.