feat: implement attribute completions for diagnostics module #19908
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements completions for
diagnostic::on_unimplemented
anddiagnostic::do_not_recommend
. Unless I missed it, I don't think there are other attributes here that deal with qualifiers likediagnostic::
so I added somewhat naive splitting on::
and then made it so that it is stripped before being used in the label and snippet. Similarly, incomplete_known_attribute_input
we first need to check if the qualifier is present instead of assuming thatas_single_name_ref
will work.I also noticed that
must_use
is currently duplicated in functions and traits since it already shows up initem
😄Closes #19892