[tutorials] Disable tmva100_DataPreparation tutorial on Windows
#19594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 21 files 21 suites 3d 7h 20m 34s ⏱️ For more details on these failures, see this check. Results for commit c93aa93. ♻️ This comment has been updated with latest results. |
|
#19579 found this during testing, but was unfortunately merged before the CI could complete... |
hahnjo
approved these changes
Aug 11, 2025
Like this, we make sure that other tutorials that import helper functions from the tmva101_Training tutorial don't unnecessarily inherit a dependency on xgboost. The problem that xgboost could not be imported before ROOT was also fixed upstream in LLVM.
In commit 042f698, I removed the usage of the `tmva10*.py` wild card for vetoing if xgboost is not found, because it caused false positives: the `tmva100_DataPreparation` tutorial is actually not using xgboost at all. But now we see in the nightlies that this tutorial crashes on Windows, so it needs to be vetoed in that case.
The problem with gracefully exiting in case of missing input is that when using the tutorial as a unit test is that it will apparently pass while it didn't even run. This was the case for the `tmva102_Testing` tutorial, which depends on a model generated by `tmva101_Training`. The input file check should be removed, and the tutorial correctly added correctly to the veto list if `tmva101_Training.py` is also disabled.
The tmva101 and tmva102 tutorials sequentially depend on tmva100, which depends on RDataFrame. So if RDataFrame is switched off, these tutorials need to be disabled too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit 042f698, I removed the usage of the
tmva10*.pywild card for vetoing if xgboost is not found, because it caused false positives: thetmva100_DataPreparationtutorial is actually not using xgboost at all.But now we see in the nightlies that this tutorial crashes on Windows, so it needs to be vetoed in that case.
Also, in a separate commit, move
import xgboostinside the main function of the tmva101 tutorial, such that other tutorials that use the tmva101 tutorial as a library don't inherit this dependency