Be more lax on what merged PRs we detect, but post an alert.#189
Draft
Zimmi48 wants to merge 1 commit intorocq-prover:masterfrom
Draft
Be more lax on what merged PRs we detect, but post an alert.#189Zimmi48 wants to merge 1 commit intorocq-prover:masterfrom
Zimmi48 wants to merge 1 commit intorocq-prover:masterfrom
Conversation
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It happens more often than I expected that maintainers use the merge button, even though it's explicitly forbidden in the merging rules. Examples by different maintainers:
Therefore, it can happen that we miss PRs for which backporting would have been required. This is what has happened in the case of rocq-prover/rocq#11629, where the backporting process was handled manually.
This PR detects these offending PRs, but as is it is incomplete because in cases where we merge subtrees coming from other repositories, such as in the case of rocq-prover/rocq#8778, we might get confused by a bunch of merge commits that are not from the Coq repository. We can think of various ways to solve this issue.
In case we notice a wrong merge commit message, we could alert the maintainer that they are not following the documentation. Currently, all the code does is to put a warning in the log.