Open
Conversation
Before anything, that contained a starting SVG tag was identified as an SVG. This patch should make the detection a little more robust. 🤞 See issue rails#107 for the case of identifying JS as SVG See issue rails#111 for the case of identifying CSV as SVG See issue rails#125 for the case of identifying audio1.mp3 as SVG
alexanderadam
force-pushed
the
fix/improve_svg_detection_issue_107
branch
from
d80bad5 to
631b328
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi folks,
anything, that contained a starting SVG tag (
<svg) somewhere in the first characters, was identified as an SVG. This patch should make the detection a little more robust. 🤞See issue #107 for the case of identifying JS as SVG
See issue #111 for the case of identifying CSV as SVG
See issue #125 for the case of identifying
audio1.mp3as SVGPS: I'm looking for a new adventure in case anybody is looking to hire or work with a Ruby/Rails/Crystal dev