Skip to content

Conversation

@mpl1018
Copy link
Contributor

@mpl1018 mpl1018 commented May 8, 2025

  • Added firefox support (only changes manifest)
  • Added script to build extensions for chrome and firefox, with their own manifest
  • Updated readme

@mpl1018 mpl1018 requested a review from CescHolly May 8, 2025 09:20
@pullpo-for-slack
Copy link

🔗Pullpo.io Slack PR-Channel

@pullpo-for-slack
Copy link

pullpo-for-slack bot commented May 8, 2025

AI Analysis

Purpose of the changes:

This pull request introduces a new build system for creating browser extensions for Chrome and Firefox, along with necessary manifest files and updates to the README for improved installation instructions.

Detailed file changes

(dropdown):
  • In file build-manifests.js:

    • Introduced a new script to handle building Chrome and Firefox extensions, including directory creation and file copying.
    • Implemented functions for copying files and ensuring directory existence to streamline the build process.
    • Added command line argument handling to specify the target browser for the build.
  • In file README.md:

    • Updated the description to reflect that the extension is for both Chrome and Firefox.
    • Added detailed instructions for building the extension from source for both Chrome and Firefox.
  • In file manifest-base.json:

    • Created a new base manifest file for the extension, including permissions and content scripts for GitHub.
  • In file manifest.json:

    • Removed the old manifest.json file as it is replaced by the new manifest-base.json.
  • In file package.json:

    • Introduced a package.json file to manage build scripts for the extension.
  • In file .gitignore:

    • Added a .gitignore file to exclude build output and IDE/editor specific files.

Copy link
Contributor

@CescHolly CescHolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets go to firefox

@mpl1018 mpl1018 merged commit 4c34333 into main May 8, 2025
@mpl1018 mpl1018 mentioned this pull request May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants