Skip to content

Conversation

@CescHolly
Copy link
Contributor

Closes # #20

📑 Description

These changes apply the user-requested dark-theme detection method, using the browser's preferences.
I also fixed a pending bug with how fallback popups work in firefox and extended its functionality to allow for separation of concerns in css styling.

ℹ️ Additional Information

The only "weird" behavior now is that if the browser preference is dark, and the github's theme is set to light (no in syn with browser), the dark buttons will appear... Maybe we should also try if we can fix this before/after merging?

@CescHolly CescHolly requested a review from mpl1018 October 21, 2025 14:29
@pullpo-for-slack
Copy link

🔗Pullpo.io Slack PR-Channel

@pullpo-for-slack
Copy link

pullpo-for-slack bot commented Oct 21, 2025

AI Analysis

Purpose of the changes:

The changes aim to enhance the styling and functionality of the popup interface for a browser extension, including improvements for dark mode and a new installation popup, while also optimizing the structure of the related JavaScript code.

Improvements and suggestions

(dropdown):
  • In file src/popups/install-pullpo.js / getOrgFromUrl

Issue:
The function does not handle cases where the root element is null, leading to a potential runtime error.

Suggested solution:
Add a check to ensure 'root' is not null before attempting to access 'dataset.queryParams'.

  • In file src/popups/install-pullpo.js / attachListeners

Issue:
The function does not validate the presence of the 'orgSlug' variable, which could lead to errors if the URL is malformed.

Suggested solution:
Implement validation to ensure 'orgSlug' is defined before using it in URLs.

Detailed file changes

(dropdown):
  • In file src/style.css:

    • Refactored CSS rules for better readability by aligning properties.
    • Added new styles for selected type labels and dark mode support.
  • In file src/popups/style.css:

    • Removed unnecessary styles for setting groups and support sections.
    • Updated dark mode styles for improved visual consistency.
  • In file src/popups/install-pullpo.js:

    • Refactored the method for extracting the organization from the URL.
    • Consolidated popup closing logic into a reusable function.
  • In file src/popups/install-pullpo.css:

    • Introduced a new stylesheet for the installation popup to maintain consistent styling.
  • In file src/content/popup.js:

    • Enhanced the modal opening function to ensure clean state by removing existing modals.
    • Improved the handling of script imports for dynamic modal content.
  • In file src/background.js:

    • Removed deprecated message handling for opening popups, streamlining background script functionality.

@CescHolly
Copy link
Contributor Author

[UPDATE]: I fixed the issue with having browser and explicit themes in the taskbar. The popups always follow system preference since they appear from the browser's navigation bar anyway.

This is ready to ship once reviewed @mpl1018

Copy link
Contributor

@mpl1018 mpl1018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay! I'll update the version in Chrome and Firefox stores now 👌

@mpl1018 mpl1018 merged commit 9c810a7 into main Oct 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants