Skip to content

Conversation

@rodmoreno
Copy link
Contributor

create from safari-web-extension-converter

📑 Description

Added support for Safari, I've created Xcode project for Safari support using xcrun safari-web-extension-converter command. Xcode project it's using Chrome build assets so it's important build the project and then can be run Xcode project.

✅ Checks

  • My pull request adheres to the code style of this project

ℹ️ Additional Information

I've already tested on Safari 18.5 on macOS 15.5, tested Github and Gitlab and works perfectly.

create from safari-web-extension-converter
@pullpo-for-slack
Copy link

pullpo-for-slack bot commented Jun 12, 2025

AI Analysis

Purpose of the changes:

This pull request introduces a new Xcode project for a Safari extension called 'Conventional Comments', which includes necessary configuration files and a storyboard for the user interface.

Detailed file changes

(dropdown):
  • In file safari/Conventional Comments/Conventional Comments.xcodeproj/project.pbxproj:

    • Added a new Xcode project configuration file for the 'Conventional Comments' extension.
    • Defined build targets for the application, unit tests, and UI tests.
    • Included references to source files, resources, and entitlements necessary for the extension.
  • In file safari/Conventional Comments/Conventional Comments/Base.lproj/Main.storyboard:

    • Created a new storyboard file for the user interface of the 'Conventional Comments' extension.
    • Defined the main application window and menu structure including 'About', 'Hide', and 'Quit' options.
    • Set up a web view within the view controller to display content.

@mpl1018 mpl1018 requested review from CescHolly and mpl1018 June 26, 2025 12:31
@pullpo-for-slack
Copy link

🔗Pullpo.io Slack PR-Channel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant