Gitlab compatibility #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces compatibility for the Conventional Comments extension
with GitLab and refines the CSS selectors for improved accuracy and
maintainability.
Key changes:
- Updated `manifest-base.json` to include `*://gitlab.com/*` in
`host_permissions` and `content_scripts.matches`.
- Modified `content.js`:
- Added comments to distinguish between GitHub and GitLab selectors.
- Updated GitLab CSS selectors to be more specific:
- `textarea[name="note[note]"]` (for MR discussions, incl. line comments)
- `textarea[name="work-item-add-or-edit-comment"]` (for Issue discussions, incl. new Issue descriptions & comments)
- Removed previously used ID-based GitLab selectors.
The extension has been tested and confirmed to work on both GitLab and
GitHub after these changes.
align comments for selectors
AI AnalysisPurpose of the changes:The changes aim to extend the functionality of a browser extension to support GitLab in addition to GitHub, allowing users to interact with textareas for comments and discussions on both platforms.
|
Contributor
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Description
This PR introduces compatibility for the Conventional Comments extension with GitLab
✅ Checks
ℹ️ Additional Information
Key changes:
manifest-base.jsonto include*://gitlab.com/*inhost_permissionsandcontent_scripts.matches.content.js:textarea[name="note[note]"](for MR discussions, incl. line comments)textarea[name="work-item-add-or-edit-comment"](for Issue discussions, incl. new Issue descriptions & comments)