fix(auto-reconciler): fix scheduling, notifications, and drift detection#239
Merged
JeroenSoeters merged 4 commits intomainfrom Feb 13, 2026
Merged
fix(auto-reconciler): fix scheduling, notifications, and drift detection#239JeroenSoeters merged 4 commits intomainfrom
JeroenSoeters merged 4 commits intomainfrom
Conversation
The auto-reconciler was only reconciling once because it wasn't receiving notifications when changesets completed. The changeset executor sends ChangesetCompleted messages, but the auto-reconciler was waiting for a ReconcileComplete message that was never sent. - Set NotifyOnComplete: true when starting changesets - Handle ChangesetCompleted instead of the unused ReconcileComplete - Remove dead code: ReconcileComplete struct and its handler
- Use minimum 1s delay instead of 0s for SendAfter (0s doesn't work reliably in Ergo framework) - Add logging for number of stacks found at startup - Change policy display from "Interval: 2m" to "AutoReconcile: 2m" for consistency with "TTL: 1h" format
…t detection The GetResourcesAtLastReconcile query was getting the latest version of resources, which includes out-of-band changes pulled in by sync. This meant auto-reconciler was comparing synced state vs synced state, detecting no drift. Fixed to get resources from the last USER reconcile command (excluding auto-reconciler commands), which represents the declared state that should be enforced. Also improved display format to "Auto-reconcile: every 2m".
JeroenSoeters
force-pushed
the
fix/auto-reconciler-bugs
branch
from
1bb4a97 to
d1cfe05
Compare
discount-elf
approved these changes
Feb 13, 2026
discount-elf
previously approved these changes
Feb 13, 2026
Moved manual test cases to ~/dev/pel/formae-test-cases/ for local testing. Fixed gofmt formatting issue in auto_reconciler.go.
discount-elf
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes several bugs in the auto-reconciler that prevented it from working correctly:
ChangesetCompletedmessages to know when to schedule the next reconcileSendAfter(0s doesn't work reliably in Ergo)GetResourcesAtLastReconcilenow gets declared state from the last USER reconcile command, not the latest synced version which includes out-of-band changesAlso improves display format: "Auto-reconcile: every 2m"