Valgrind: Return error for unsupported check=new on Valgrind < 3.21. v7.0.52 #4301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duiniuluantanqin
requested review from
winlinvip,
johzzy,
xiaozhihong and
chundonglinlin
suzp1984
approved these changes
Mar 14, 2025
duiniuluantanqin
force-pushed
the
feature/valgrind
branch
from
42fe78e to
bfdd0ab
Compare
suzp1984
approved these changes
Mar 14, 2025
winlinvip
force-pushed
the
develop
branch
2 times, most recently
from
195435d to
97e2b64
Compare
duiniuluantanqin
changed the title
valgrind?check=full when valgrind?check=new is unavailable.
winlinvip
changed the title
valgrind?check=full when valgrind?check=new is unavailable.
winlinvip
changed the title
winlinvip
changed the title
winlinvip
force-pushed
the
feature/valgrind
branch
from
5a2f8dc to
981a47c
Compare
winlinvip
changed the title
winlinvip
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
valgrind?check=newAPI parameter usesVALGRIND_DO_NEW_LEAK_CHECKwhich is only available in Valgrind 3.21+. On older versions like CentOS's default Valgrind 3.16, this causes undefined behavior since the macro is not defined.Solution
VALGRIND_DO_NEW_LEAK_CHECKavailability before processing the requestERROR_NOT_SUPPORTEDwith version information when unsupportedChanges
check=newparameter compatibilityFixes compatibility issues with older Valgrind versions commonly found in enterprise Linux distributions.
Co-authored-by: Jacob Su suzp1984@gmail.com