This repository was archived by the owner on Feb 18, 2025. It is now read-only.
Dbre 2030 bugfix gtid anonymous skip #1429
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting `MySQLOrchestratorUseMutualTLS=false` prevented _any_ SSL connection to the backend server, as it guarded the call to `SetupMySQLOrchestratorTLS`. This behaviour is inconsistent with the documentation. To keep full backwards compatibility but also correct this bug, a value set in `MySQLOrchestratorSSLCAFile` will now result in connections that use SSL. Further, unlike the topology code path, `MySQLOrchestratorUseMutualTLS` was not referenced within `SetupMySQLOrchestratorTLS`. As such, all connections required a (valid) client key pair to be provided, preventing the application from starting. This change unifies the code paths.
Port fixup ssl for mysql backend
In order to allow movement of 5.7 replica under a 5.5 master, allow special binlog filtering to also happen on 5.5 master with 5.7 replicas. Furthermore, generalize check so that it applies to all flavours of MySQL instead of _only_ to vanilla mysql
Upload artifacts created by builds
[DBRE-876] Make binlog filtering on 5.7 less restrictive
DO NOT MERGE
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: https://github.com/openark/orchestrator/issues/0123456789
Description
This PR [briefly explain what is does]