[IMP] Hr_holidays: filtered available dates of carryover accrual#5020
Merged
Mahmoudk3m merged 1 commit intomaster-hr-onboarding-moalifrom Feb 20, 2026
Conversation
|
This PR targets the un-managed branch odoo-dev/odoo:master-hr-onboarding-moali, it needs to be retargeted before it can be merged. |
Mahmoudk3m
requested changes
Feb 17, 2026
Mahmoudk3m
left a comment
Mahmoudk3m
left a comment
There was a problem hiding this comment.
Thanks for your work 🚀
Left some comments
addons/hr_holidays/static/src/components/day_selection/day_selection.js
Outdated
Show resolved
Hide resolved
addons/hr_holidays/static/src/components/day_selection/day_selection.js
Outdated
Show resolved
Hide resolved
addons/hr_holidays/static/src/components/day_selection/day_selection.js
Outdated
Show resolved
Hide resolved
addons/hr_holidays/static/src/components/day_selection/day_selection.js
Outdated
Show resolved
Hide resolved
Mahmoudk3m
requested changes
Feb 18, 2026
addons/hr_holidays/static/src/components/day_selection/day_selection.js
Outdated
Show resolved
Hide resolved
addons/hr_holidays/static/src/components/day_selection/day_selection.js
Outdated
Show resolved
Hide resolved
addons/hr_holidays/static/src/components/day_selection/day_selection.js
Outdated
Show resolved
Hide resolved
addons/hr_holidays/static/src/components/day_selection/day_selection.js
Outdated
Show resolved
Hide resolved
Comment on lines
32
to
39
| registry.category("fields").add("day_selection", { | ||
| ...selectionField, | ||
| component: DaySelection, | ||
|
|
||
| extractProps: ({ options }) => ({ | ||
| monthField: options?.month_field, | ||
| }), | ||
| }); |
There was a problem hiding this comment.
Suggested change
| registry.category("fields").add("day_selection", { | |
| ...selectionField, | |
| component: DaySelection, | |
| extractProps: ({ options }) => ({ | |
| monthField: options?.month_field, | |
| }), | |
| }); | |
| export const daySelection = { | |
| ...selectionField, | |
| component: DaySelection, | |
| extractProps: ({ options }) => ({ | |
| monthField: options.month_field, | |
| }), | |
| } | |
| registry.category("fields").add("day_selection", daySelection); |
Just a preference for better readability.
Filtered the selection values of the available dates based on the selected month in the carryover accrual plans and milestones. Consequenty a custom component was built to filter the avaialable dates for selection in a single as the month being selected. Task: 5920859
mohamedakhalil18
force-pushed
the
master-hr-onboarding-dynamic_date_selection-moali
branch
from
dfbaa2a to
dc7a969
Compare
Mahmoudk3m
deleted the
master-hr-onboarding-dynamic_date_selection-moali
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filtered the selection values of the available dates based on the selected month in the carryover accrual plans and milestones
Task: 5920859