-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix(misc): update @types/node to v20.19.9 to support fetch API #32092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
b47b5ec
to
9751941
Compare
View your CI Pipeline Execution ↗ for commit 812c6fe
☁️ Nx Cloud last updated this comment at |
packages/nx/src/plugins/js/lock-file/__fixtures__/pnpm-semver-range-specifier/pnpm-lock.yaml.ts
Outdated
Show resolved
Hide resolved
9751941
to
d4c9f8e
Compare
Fixes #29714 too |
- Update @types/node from 18.16.9 to 20.19.9 across all packages - Resolves "fetch is undefined" TypeScript errors in NestJS projects - Aligns with Nx's base Node.js 20.19.0 support requirement Fixes #31637
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
7da119a
to
812c6fe
Compare
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
## Current Behavior Nx currently installs an outdated `@types/node` version (18.16.9) which lacks TypeScript definitions for the native `fetch` API introduced in Node.js 18. This causes "fetch is undefined" TypeScript errors in NestJS projects and other Node.js applications when using webpack transformers or other build tools. ## Expected Behavior The `fetch` API should be properly typed in TypeScript without requiring additional type packages or workarounds. Users should be able to use the native fetch API in Node.js applications without TypeScript compilation errors. ## Related Issue(s) Fixes #31637 Fixes #29714 --------- Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com> Co-authored-by: Colum Ferry <cferry09@gmail.com> (cherry picked from commit 6ce1061)
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Nx currently installs an outdated
@types/node
version (18.16.9) which lacks TypeScript definitions for the nativefetch
API introduced in Node.js 18. This causes "fetch is undefined" TypeScript errors in NestJS projects and other Node.js applications when using webpack transformers or other build tools.Expected Behavior
The
fetch
API should be properly typed in TypeScript without requiring additional type packages or workarounds. Users should be able to use the native fetch API in Node.js applications without TypeScript compilation errors.Related Issue(s)
Fixes #31637
Fixes #29714