Adds calls to cmdResponse_out for both OK and EXECUTION_ERROR conditions Fixes #3897 #3926
Conversation
|
Thanks! |
|
I'm basing our next mission at the University of Virginia on F' and I want to give something back. This is my first pull request on this project, so pardon me if I totally screwed up! Thanks. Mike |
thomas-bc
left a comment
thomas-bc
left a comment
There was a problem hiding this comment.
Looks like the helper method is spelled out incorrectly. Should look like
this->cmdResponse_out(<args>);
|
Whoops, forgot to click "Save" before I pushed! |
![github-advanced-security[bot]](http://www.gproxx.com/https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| Os::RawTime::Status stat = time_now.now(); | ||
| if (stat != Os::RawTime::OP_OK) { | ||
| this->log_WARNING_HI_SetCurrentTimeError(stat); | ||
| this->cmdResponse_out(opCode,cmdSeq,Fw::CmdResponse::EXECUTION_ERROR); |
Check warning
Code scanning / CodeQL
Unchecked function argument Warning
| Os::RawTime::Status stat = time_now.now(); | ||
| if (stat != Os::RawTime::OP_OK) { | ||
| this->log_WARNING_HI_SetCurrentTimeError(stat); | ||
| this->cmdResponse_out(opCode,cmdSeq,Fw::CmdResponse::EXECUTION_ERROR); |
Check warning
Code scanning / CodeQL
Unchecked function argument Warning
| m_epoch_fw_time = Fw::Time(seconds_now, 0); | ||
| m_epoch_os_time = time_now; | ||
| m_epoch_valid = true; | ||
| this->cmdResponse_out(opCode,cmdSeq,Fw::CmdResponse::OK); |
Check warning
Code scanning / CodeQL
Unchecked function argument Warning
| m_epoch_fw_time = Fw::Time(seconds_now, 0); | ||
| m_epoch_os_time = time_now; | ||
| m_epoch_valid = true; | ||
| this->cmdResponse_out(opCode,cmdSeq,Fw::CmdResponse::OK); |
Check warning
Code scanning / CodeQL
Unchecked function argument Warning
|
One thing I'm not clear on: do I close the PR or do you close it? Thanks. Mike |
|
We're all set! Thanks a lot for the contribution @MikeMcPherson |
|
Thank you, happy to be able to contribute! I'll try somethiing more difficult next time. |
4 participants
Change Description
Adds calls to cmdResponse_out in Svc::OsTime::SetCurrentTime_cmdHandler for both OK and EXECUTION_ERROR conditions.
Rationale
Fixes #3897.
Testing/Review Recommendations
Run unit tests
Future Work
None