Restrict TCP subtopologies to supported platforms #3903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-bc
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Restricts ComCcsds and ComFprime to Posix SOCKETS platforms.
Rationale
These are the same restrictions placed on Drv.TcpClient, which both of these subtopologies rely on. Without these restrictions, the F Prime framework fails to build on platforms without TCP support.
While the references to Drv.TcpClient are in the ComCcsdsConfig and ComFprimeConfig subfolders, the subtopologies depend on these configuration folders in order to compile.
Testing/Review Recommendations
N/A
Future Work
We ought to have CI checks that would prevent these kinds of regressions.