Skip to content

[docs][combobox] Add a @tanstack/react-query demo#3855

Closed
mj12albert wants to merge 18 commits intomui:masterfrom
mj12albert:docs/tanstack-query
Closed

[docs][combobox] Add a @tanstack/react-query demo#3855
mj12albert wants to merge 18 commits intomui:masterfrom
mj12albert:docs/tanstack-query

Conversation

@mj12albert
Copy link
Member

@mj12albert mj12albert commented Jan 24, 2026

@mj12albert mj12albert changed the title [docs] [docs][combobox] Jan 24, 2026
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 24, 2026

commit: cac78c2

@mj12albert mj12albert changed the title [docs][combobox] [docs][combobox] Add a @tanstack/react-query demo Jan 24, 2026
@mj12albert mj12albert added the docs Improvements or additions to the documentation. label Jan 24, 2026
@mui-bot
Copy link

mui-bot commented Jan 24, 2026

Bundle size report

Bundle Parsed size Gzip size
@base-ui/react 0B(0.00%) 0B(0.00%)

Details of bundle changes


Check out the code infra dashboard for more information about this PR.

@netlify
Copy link

netlify bot commented Jan 24, 2026

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit cac78c2
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/69bd5d3ab846f50008b5b46b
😎 Deploy Preview https://deploy-preview-3855--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mj12albert mj12albert force-pushed the docs/tanstack-query branch 2 times, most recently from 248faeb to a0d200c Compare January 25, 2026 06:44
@mj12albert mj12albert marked this pull request as ready for review January 25, 2026 11:50
greptile-apps[bot]

This comment was marked as off-topic.

@mj12albert mj12albert force-pushed the docs/tanstack-query branch 2 times, most recently from ddc2136 to e08f4f3 Compare January 27, 2026 10:40
@atomiks
Copy link
Contributor

atomiks commented Jan 30, 2026

Couple things:

  • It's not super obvious in the example how to see infinite scroll behavior. You have to type a short string e.g. "a" instead of "Aliens" to see it load more items when reaching the bottom
  • Shouldn't it try to fetch more eagerly (well before the bottom) so there isn't a noticeable delay? Infinite scroll feeds usually avoid reaching the bottom

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jan 30, 2026
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Feb 2, 2026
@mj12albert
Copy link
Member Author

  • It's not super obvious in the example how to see infinite scroll behavior. You have to type a short string e.g. "a" instead of "Aliens" to see it load more items when reaching the bottom
  • Shouldn't it try to fetch more eagerly (well before the bottom) so there isn't a noticeable delay? Infinite scroll feeds usually avoid reaching the bottom

👌 updated the placeholder text and changed the "fetch next page" threshold to be approx 10 items from the end

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Mar 18, 2026
Copy link
Member

@aarongarciah aarongarciah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just merged #4384 and now we use a new font. From now on, we'll only use 400 or 700 weights for all of the docs shell and demos.

@mj12albert
Copy link
Member Author

@aarongarciah I've fixed the fonts, are you good wit hthe UX of this? 😬

Copy link
Member

@aarongarciah aarongarciah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • When there's a selected movie and you add some more text, the no matches text is displayed but the selected movie is still visible. I think the selected movie should be hidden when it doesn't match the query. Same as we do in non-async comboboxes e.g. the hero demo.

    Kapture.2026-03-20.at.17.49.33.mp4
  • Q: I added "Jaws 2" to the list of movies locally. I selected "Jaws". I opened the popup again and I only see "Jaws". Since "Jaws 2" matches the query, should it be listed? Or is it intended that only the selected movie is displayed when opening the popup due to the async nature of the search?
    image

  • When overscrolling the list (I'm using macOS), you can see past the popover at the bottom. This also happens in other existing demos like Async search (single) and Async search (multiple).

    Kapture.2026-03-20.at.17.28.13.mp4
  • Although I understand the "e.g. The" placeholder is there to help users see more results, I think it's not very realistic. Not sure what to put there if we don't use a real API that returns way more results with "regular" words.

  • Ideally writing "the" should display movies starting with "the" first. It'd feel more realistic, although it'd make the demo more complex.

  • Do we want to avoid querying openlibrary.org? I'm wondering if it'd simplify the demo and return way more results, at the cost of using a 3rd party API (network latency, external dependency, etc.). I'm not sure about the team's preference so take this comment with a pinch of salt.

@colmtuite
Copy link
Contributor

Closing this for now just to avoid crossed wires. Will likely reopen it in a couple months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[combobox] Example request: Combobox + infinite async data

6 participants