This repository was archived by the owner on Jan 18, 2021. It is now read-only.
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #854 +/- ##
============================================
+ Coverage 76.85% 76.85% +<.01%
- Complexity 1229 1230 +1
============================================
Files 219 219
Lines 4467 4468 +1
Branches 334 335 +1
============================================
+ Hits 3433 3434 +1
Misses 922 922
Partials 112 112
Continue to review full report at Codecov.
|
koral--
approved these changes
Jan 11, 2020
Member
Author
|
Thank you for review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #847 - users can configure pom in the build.file so our logic cannot blindly add XML nodes - we need to check for existence of nodes.
This is a wider problem - this PR fixes one instance - see the TODO in the code.
Happy New Year everybody :-)