docs: fix invalid argument in cargo-wdk command in README.md #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: justanotheranonymoususer <justanotheranonymoususer@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the installation command in the cargo-wdk README to address the cargo error regarding multiple packages with binaries.
- Updated installation command to explicitly specify the package name
- Removed the redundant "--bin" flag which was causing the error
Comments suppressed due to low confidence (1)
crates/cargo-wdk/README.md:32
- The updated command now explicitly specifies the package name which resolves the cargo error. Consider adding an inline comment referencing the cargo issue (rust-lang/cargo#4830) to clarify for future maintainers why this change was made.
cargo install --git https://github.com/microsoft/windows-drivers-rs.git cargo-wdk --locked
gurry
approved these changes
Jun 10, 2025
wmmc88
approved these changes
Jun 10, 2025
Collaborator
wmmc88
left a comment
wmmc88
left a comment
There was a problem hiding this comment.
thanks for the pr @justanotheranonymoususer!
wmmc88
changed the title
wmmc88
changed the title
gurry
approved these changes
Jun 11, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current command fails with:
See rust-lang/cargo#4830.