Quantization: lm_head quantization, k_quant_down heuristic, No zero offset while packing#2137
Merged
Quantization: lm_head quantization, k_quant_down heuristic, No zero offset while packing#2137
Conversation
devang-ml
reviewed
Sep 4, 2025
devang-ml
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Gptqand olive quant checkpoint now supports lm_head quantizationSelectiveMixedPrecisionhas a new heuristic calledk_quant_downwhich is similar tok_quant_mixedbut only takes thedown_projlinears andlm_head.QuantLinearpacking now doesn't do the gptq style -1 offset to the zero points while packing. This causes issues with asymmetric quantization when any zero point value is 0 as the values are expected to be unsigned int. It also now has afrom_tensormethod that can be used to create a new instance from already quantized weights.Checklist before requesting a review
lintrunner -a(Optional) Issue link