Skip to content

Adding clip models examples#1793

Closed
kaunain-98 wants to merge 5 commits intomicrosoft:mainfrom
kaunain-98:Intel_clip_pr
Closed

Adding clip models examples#1793
kaunain-98 wants to merge 5 commits intomicrosoft:mainfrom
kaunain-98:Intel_clip_pr

Conversation

@kaunain-98
Copy link
Contributor

Describe your changes

Checklist before requesting a review

  • Add unit tests for this change.
  • Make sure all tests can pass.
  • Update documents if necessary.
  • Lint and apply fixes to your code by running lintrunner -a
  • Is this a user-facing change? If yes, give a description of this change to be included in the release notes.
  • Is this PR including examples changes? If yes, please remember to update example documentation in a follow-up PR.

(Optional) Issue link

Copy link
Contributor

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lintrunner found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@xiaoyu-work
Copy link
Collaborator

xiaoyu-work commented Apr 24, 2025

Are those 3 user scripts same? If so, we can put one single script in openvino folder and share the script and README like how current clip examples are doing https://github.com/microsoft/Olive/tree/main/examples/clip.

model name can be passed to conceptual_captions_dataset in load_dataset_config in config file, and get it by **kwargs

@@ -0,0 +1,122 @@
from io import BytesIO

Check warning

Code scanning / lintrunner

RUFF-FORMAT/format Warning

Run lintrunner -a to apply this patch.
@xiaoyu-work xiaoyu-work mentioned this pull request Apr 25, 2025
6 tasks
xiaoyu-work added a commit that referenced this pull request Apr 25, 2025
## Describe your changes
Adding clip models examples. Copy of
#1793
## Checklist before requesting a review
- [ ] Add unit tests for this change.
- [ ] Make sure all tests can pass.
- [ ] Update documents if necessary.
- [ ] Lint and apply fixes to your code by running `lintrunner -a`
- [ ] Is this a user-facing change? If yes, give a description of this
change to be included in the release notes.
- [ ] Is this PR including examples changes? If yes, please remember to
update [example
documentation](https://github.com/microsoft/Olive/blob/main/docs/source/examples.md)
in a follow-up PR.

## (Optional) Issue link

---------

Co-authored-by: Kaunain <kaunain.ahmed@intel.com>
@xiaoyu-work
Copy link
Collaborator

Closing as #1796 was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants