Remove OnPrem on Azure Key Vault #3598
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could not find a linked ADO work item. Please link one by using the pattern 'AB#' followed by the relevant work item number. You may use the 'Fixes' keyword to automatically resolve the work item when the pull request is merged. E.g. 'Fixes AB#1234' |
grobyns
previously approved these changes
Apr 30, 2025
src/System Application/App/Azure Key Vault/src/AzureKeyVaultImpl.Codeunit.al
Outdated
Show resolved
Hide resolved
darjoo
approved these changes
Apr 30, 2025
grobyns
approved these changes
Apr 30, 2025
WaelAbuSeada
requested changes
Apr 30, 2025
Member
WaelAbuSeada
left a comment
WaelAbuSeada
left a comment
There was a problem hiding this comment.
This is not the best approach. Lets discuss this internally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Change Azure Key Keyvault to rely on Publisher Info instead of onprem scope.
This will ensure only 1p code is allowed to call MS key vaults.
Work Item(s)
Fixes #