magento csp dependency issue fixed

[magentoabu]

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Magento_Paypal module has dependency on Magento_Csp module #38764

Manual testing scenarios (*)

1. This file has a dependency on Magento_Csp: https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Paypal/Model/Config.php#L9
2. Declared it as a dependency in the module.xml

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @magentoabu. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[magentoabu]

@magento run all tests

[magentoabu]

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests, Static Tests

[engcom-Hotel]

@magento run all tests

[engcom-Bravo]

@magento run all tests

[engcom-Bravo]

Hi @magentoabu,

Thanks for the collaboration & contribution!

❌ QA Failed

Preconditions:

• Install fresh Magento 2.4-develop

Steps to reproduce

Disable the Magento_Csp module
Try to access the backend or frontend.

Before: ✖️ 

#63 {main} {"exception":"[object] (Error(code: 0): Cannot instantiate interface Magento\\Csp\\Model\\Collector\\MergerInterface at /usr/local/var/www/magentop/magento2/lib/internal/Magento/Framework/ObjectManager/Factory/Dynamic/Developer.php:50)"} []

After: ✔️

#63 {main} {"exception":"[object] (Error(code: 0): Cannot instantiate interface Magento\\Csp\\Model\\Collector\\MergerInterface at /usr/local/var/www/magentop/magento2/lib/internal/Magento/Framework/ObjectManager/Factory/Dynamic/Developer.php:50)"} []

Changes are not working as expected and could you please let us know if we are missing anything.

.

Thanks.

[engcom-Bravo]

Hi @magentoabu,

As per this comment #39450 (comment) the changes are not working as expected could you please let us know if we are missing anything and till then we are moving this PR to On Hold.

Thanks.

[engcom-Bravo]

Hi @magentoabu,

We appreciate your contribution and the effort you've put into this pull request. We waited for an extended period.As a result, we are closing this PR for now. If you’d like to revisit please feel free to reopen the PR with the necessary updates.

Thanks again for your contributions!