Fix issue magento#36759 Update AbstractEntity

[dimitriss93]

• Update AbstractEntity to delete custom attribute when given with empty value.

Description (*)

The method Magento\Eav\Model\Entity\AbstractEntity:_collectSaveData implements some logic to prepare the entity attributes to be saved. The code in lines 1343-1356 of this file (branch magento:2.4-develop), determines wether the attribute value will be created, updated or deleted. The code works fine except for the case when the following two conditions simultaneously happen:

1. method _canUpdateAttribute (line 1343) returns false
2. and method _isAttributeValueEmpty (line 1356) returns false (therefore the elseif branch not taken)

In this case, the expected behaviour would be _canUpdateAttribute to return 'true' and the attribute to be inserted into '$delete' array. But, the _canUpdateAttribute is not able to identify custom_attributes.
Solution: Move the code that updated the '$delete' array outside the branch so that all empty-valued attributes (both normal and custom) are pushed to '$deleted' array.

Related Pull Requests

No related PRs

Fixed Issues (if relevant)

1. Fixes we can't save customer's customAtrribute with null or blank string value #36759

Manual testing scenarios (*)

The code mentioned in the issue (#36759) description has been tested

$customer = $customerRepository->getById($customerId);
$customer->setCustomAttribute('custom_attribute',"");
$customerRepository->save($customer);

The expected behaviour, that is the 'emptied' custom attribute to be deleted from the appropriate database table, happens only if the current fix is applied.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @dimitriss93. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[dimitriss93]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[dimitriss93]

@adobe/open-source-office the CLA is signed but not visible. What actions should I take to make it visible?

[dimitriss93]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[dimitriss93]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[dimitriss93]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[dimonpvt1236]

any progress by this issue?

[dimitriss93]

@magento run Integration Tests,Functional Tests CE,Functional Tests BE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[dimitriss93]

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[dimitriss93]

https://github.com/magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B

[dimitriss93]

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[dimitriss93]

@magento run Functional Tests EE,Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[dimitriss93]

https://github.com/magento run Functional Tests CE,Functional Tests B2B