Add excludeLeavedPlayers option argument for ForEachPlayerTargetsAdjuster#14169
Open
PurpleCrowbar wants to merge 2 commits intomagefree:masterfrom
Open
Add excludeLeavedPlayers option argument for ForEachPlayerTargetsAdjuster#14169PurpleCrowbar wants to merge 2 commits intomagefree:masterfrom
PurpleCrowbar wants to merge 2 commits intomagefree:masterfrom
Conversation
Contributor
|
Pretty sure the excludeLeavedPlayers should be default behavior. Not thrilled about adding a param all over the codebase |
JayDi85
requested changes
Jan 13, 2026
| private final boolean owner; | ||
| private final boolean onlyOpponents; //Makes this a "For Each Opponent" adjuster | ||
| private final boolean onlyOpponents; // Makes this a "For Each Opponent" adjuster | ||
| private final boolean excludeLeavedPlayers; |
Member
There was a problem hiding this comment.
No needs for ForEachPlayerTargetsAdjuster, cause it used all the time (false excludeLeavedPlayers for some rare effects only, not targets setup).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The True Scriptures' (Sheoldred's back face) first ability is:
Previously, this would prompt the controller to select a creature for a player who has left the game on the current turn due to it not excluding those players by default (see #13289). This PR adds the option to use
ForEachPlayerTargetsAdjusterwith theexcludeLeavedPlayersargument (a laGame::getOpponents) which solves this problem.Tested and verified to work. Can be used to solve similar bugs with other cards that shouldn't include dead players.