Skip to content

[loongarch][DAG][FREEZE] Fix crash when FREEZE a half(f16) type on loongarch #107791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 13, 2024
Merged

[loongarch][DAG][FREEZE] Fix crash when FREEZE a half(f16) type on loongarch #107791

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d258ec3
handle FREEZE in PromoteFloatResult
yxd-ym Sep 8, 2024
e4b50bc
add fp16-promote test for loongarch
yxd-ym Sep 8, 2024
28d8257
revert FREEZE handling
yxd-ym Sep 9, 2024
d0605d7
use softPromoteHalfType
yxd-ym Sep 9, 2024
efed380
use fp regs
yxd-ym Sep 9, 2024
834bff3
do not use fp regs
yxd-ym Sep 9, 2024
82812a9
fix tests
yxd-ym Sep 9, 2024
7cd4c5b
add poison
yxd-ym Sep 9, 2024
783a317
fix tests
yxd-ym Sep 9, 2024
246cd0b
change parameter name
yxd-ym Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2655,6 +2655,7 @@ void DAGTypeLegalizer::PromoteFloatResult(SDNode *N, unsigned ResNo) {
case ISD::FLOG10:
case ISD::FNEARBYINT:
case ISD::FNEG:
case ISD::FREEZE:
case ISD::FRINT:
case ISD::FROUND:
case ISD::FROUNDEVEN:
Expand Down
15 changes: 15 additions & 0 deletions llvm/test/CodeGen/LoongArch/fp16-promote.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,3 +324,18 @@ define void @test_fmul_mem(ptr %p, ptr %q) nounwind {
store half %r, ptr %p
ret void
}

define half @freeze_half() nounwind {
; LA32-LABEL: freeze_half:
; LA32: # %bb.0:
; LA32-NEXT: fadd.s $fa0, $fa0, $fa0
; LA32-NEXT: ret
;
; LA64-LABEL: freeze_half:
; LA64: # %bb.0:
; LA64-NEXT: fadd.s $fa0, $fa0, $fa0
; LA64-NEXT: ret
%y1 = freeze half undef
%t1 = fadd half %y1, %y1
ret half %t1
}
Loading