Use WeakReference to avoid memory leaks in ArrayPool ThreadStatic field#163
Open
Use WeakReference to avoid memory leaks in ArrayPool ThreadStatic field#163
Conversation
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #99
… field This change prevents memory leaks by allowing the garbage collector to collect ArrayPool instances when memory pressure is high, instead of keeping them alive for the entire thread lifetime. Fixes #99 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_threadInstancewith a WeakReference to prevent memory leaksDetails
This change addresses issue #99 by replacing the strong reference ThreadStatic field with a WeakReference. The original implementation kept ArrayPool instances alive for the entire thread lifetime, which could lead to memory leaks in long-running applications.
Changes Made
_threadInstancefield fromArrayPool<T>toWeakReference<ArrayPool<T>>ThreadInstanceproperty to useTryGetTarget()method for safe weak reference accessBenefits
Testing
Fixes #99
🤖 Generated with Claude Code