Skip to content

[12.x] feat: Add ability to override SendQueuedNotifications job class #55942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 9, 2025
Merged

[12.x] feat: Add ability to override SendQueuedNotifications job class #55942

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c9416d0
Setup the binding and ability to swap SendQueuedNotifications::class
Orrison Jun 6, 2025
2ea6467
Add a test
Orrison Jun 6, 2025
defe367
Remove binding
Orrison Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add a test 
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
  • Loading branch information
@Orrison
Orrison committed Jun 6, 2025
commit 2ea64676b06fcd7b50ab53d04b38b63859f12a31
22 changes: 22 additions & 0 deletions tests/Notifications/NotificationChannelManagerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
use Illuminate\Notifications\Notifiable;
use Illuminate\Notifications\Notification;
use Illuminate\Notifications\SendQueuedNotifications;
use Illuminate\Queue\InteractsWithQueue;
use Illuminate\Queue\SerializesModels;
use Illuminate\Support\Collection;
use Mockery as m;
use PHPUnit\Framework\TestCase;
Expand Down Expand Up @@ -159,6 +161,26 @@ public function testNotificationCanBeQueued()

$manager->send([new NotificationChannelManagerTestNotifiable], new NotificationChannelManagerTestQueuedNotification);
}

public function testSendQueuedNotificationsCanBeOverrideViaContainer()
{
$container = new Container;
$container->instance('config', ['app.name' => 'Name', 'app.logo' => 'Logo']);
$container->instance(Dispatcher::class, $events = m::mock());
$container->instance(Bus::class, $bus = m::mock());
$bus->shouldReceive('dispatch')->with(m::type(TestSendQueuedNotifications::class));
$container->bind(SendQueuedNotifications::class, TestSendQueuedNotifications::class);
Container::setInstance($container);
$manager = m::mock(ChannelManager::class.'[driver]', [$container]);
$events->shouldReceive('listen')->once();

$manager->send([new NotificationChannelManagerTestNotifiable], new NotificationChannelManagerTestQueuedNotification);
}
}

class TestSendQueuedNotifications implements ShouldQueue
{
use InteractsWithQueue, Queueable, SerializesModels;
}

class NotificationChannelManagerTestNotifiable
Expand Down