Add test for Unique validation rule with WhereIn constraints #55351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds proper database configuration for ValidationUniqueRuleTest class by: 1. Setting up an in-memory SQLite database 2. Creating the necessary 'users' table schema for testing 3. Adding connection helper methods for database operations
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
…ints
This commit adds a test that verifies the behavior of the Unique validation rule
when using both whereIn and whereNotIn constraints together. The test demonstrates
that:
1. The whereIn constraint limits validation to only consider records matching
specified values ('admin', 'moderator', 'editor')
2. The whereNotIn constraint further excludes records with specific values ('editor')
from validation
3. Records outside these constraints are ignored when checking uniqueness
4. Non-existent values are always considered unique
This commit refactors the `testItValidatesUniqueRuleWithWhereInAndWhereNotIn` test to use the existing `EloquentModelStub` instead of a custom `User` model, resolving name conflicts with other test files in the framework.
|
Also Added whereNot to |
mohammadrasoulasghari
added a commit
to mohammadrasoulasghari/laravel-framework
that referenced
this pull request
Apr 17, 2025
…aravel#55351)" This reverts commit 437c460.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for whereIn/whereNotIn with Unique validation 🧪
This PR adds tests for the whereIn and whereNotIn methods on the Unique validation rule that were previously untested. These tests ensure future changes to this user-facing feature won’t introduce unexpected side effects.
✅ Tests cover multiple validation scenarios