[12.x] only check for soft deletes once when mass-pruning #55274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmastech
changed the title
shaedrich
added a commit
to shaedrich/framework
that referenced
this pull request
Jun 17, 2025
Co-authored-by: Luke Kuzmish <42181698+cosmastech@users.noreply.github.com> See laravel#55274 See laravel#56060 (comment)
taylorotwell
added a commit
that referenced
this pull request
Jun 17, 2025
… class (#56060) * feat(database): ✨ Add isSoftDeletable(), isPrunable(), and isMassPrunable() to model class * fix(database): 🐛 Call model method instead of command method * Restore "only check for soft deletes once when mass-pruning" Co-authored-by: Luke Kuzmish <42181698+cosmastech@users.noreply.github.com> See #55274 See #56060 (comment) * Fix typo Follow-up to 07520f2 * formatting * fix test --------- Co-authored-by: Taylor Otwell <taylor@laravel.com>
taylorotwell
added a commit
to illuminate/database
that referenced
this pull request
Jun 17, 2025
… class (#56060) * feat(database): ✨ Add isSoftDeletable(), isPrunable(), and isMassPrunable() to model class * fix(database): 🐛 Call model method instead of command method * Restore "only check for soft deletes once when mass-pruning" Co-authored-by: Luke Kuzmish <42181698+cosmastech@users.noreply.github.com> See laravel/framework#55274 See laravel/framework#56060 (comment) * Fix typo Follow-up to 07520f2225a78a183c6d02da11f662ddf207657d * formatting * fix test --------- Co-authored-by: Taylor Otwell <taylor@laravel.com>
taylorotwell
added a commit
to illuminate/routing
that referenced
this pull request
Jun 17, 2025
… class (#56060) * feat(database): ✨ Add isSoftDeletable(), isPrunable(), and isMassPrunable() to model class * fix(database): 🐛 Call model method instead of command method * Restore "only check for soft deletes once when mass-pruning" Co-authored-by: Luke Kuzmish <42181698+cosmastech@users.noreply.github.com> See laravel/framework#55274 See laravel/framework#56060 (comment) * Fix typo Follow-up to 07520f2225a78a183c6d02da11f662ddf207657d * formatting * fix test --------- Co-authored-by: Taylor Otwell <taylor@laravel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not necessary to repeatedly reflect the traits of a Model to see if it's soft-deletable. This is a very minor optimization.