Skip to content

Fix factory creation through attributes #55190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025
Merged

Fix factory creation through attributes #55190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix creation of a Factory via attribute so that configure method is c… 
…alled
  • Loading branch information
@davidstoker
davidstoker committed Mar 27, 2025
commit a981863c3ae3f7d5f4143cbb1d57761bbacb804f
2 changes: 1 addition & 1 deletion src/Illuminate/Database/Eloquent/Factories/HasFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ protected static function getUseFactoryAttribute()
if ($attributes !== []) {
$useFactory = $attributes[0]->newInstance();

$factory = new $useFactory->factoryClass;
$factory = $useFactory->factoryClass::new();

$factory->guessModelNamesUsing(fn () => static::class);

Expand Down
Loading