Skip to content

[11.x] Fix routeCollection get method return value when searching by dot not… #54672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 18, 2025
Merged

[11.x] Fix routeCollection get method return value when searching by dot not… #54672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
77807ce
Fix routeCollection get method return value when searching by dot not…
abdel-aouby Feb 18, 2025
2069105
remove unused import
abdel-aouby Feb 18, 2025
1ab173a
Update RouteCollection.php
taylorotwell Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/Illuminate/Routing/RouteCollection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

use Illuminate\Container\Container;
use Illuminate\Http\Request;
use Illuminate\Support\Arr;

class RouteCollection extends AbstractRouteCollection
{
Expand Down Expand Up @@ -171,7 +170,7 @@ public function match(Request $request)
*/
public function get($method = null)
{
return is_null($method) ? $this->getRoutes() : Arr::get($this->routes, $method, []);
return is_null($method) ? $this->getRoutes() : ($this->routes[$method] ?? []);
}

/**
Expand Down
18 changes: 18 additions & 0 deletions tests/Routing/RouteCollectionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,24 @@ public function testRouteCollectionCanRetrieveByAction()
$this->assertSame($action, $routeIndex->getAction());
}

public function testRouteCollectionCanRetrieveByMethod()
{
$this->routeCollection->add($routeIndex = new Route('GET', 'foo/index', $action = [
'uses' => 'FooController@index',
'as' => 'route_name',
]));

$this->assertCount(1, $this->routeCollection->get('GET'));
$this->assertCount(0, $this->routeCollection->get('GET.foo/index'));
$this->assertSame($routeIndex, $this->routeCollection->get('GET')['foo/index']);

$this->routeCollection->add($routeShow = new Route('GET', 'bar/show', [
'uses' => 'BarController@show',
'as' => 'bar_show',
]));
$this->assertCount(2, $this->routeCollection->get('GET'));
}

public function testRouteCollectionCanGetIterator()
{
$this->routeCollection->add(new Route('GET', 'foo/index', [
Expand Down
Loading