Skip to content

[12.x] Add NamedScope attribute #54450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Mar 19, 2025
Merged

[12.x] Add NamedScope attribute #54450

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
6915a93
Add NamedScope attribute
shaedrich Feb 3, 2025
1b11b31
StyleCI
shaedrich Feb 3, 2025
df67443
Make Model::getAttributedNamedScope() protected
shaedrich Feb 5, 2025
19590d2
wip
crynobone Feb 6, 2025
d6fc922
wip
crynobone Feb 6, 2025
6d5aa00
wip
crynobone Feb 6, 2025
3d3b2cd
wip
crynobone Feb 6, 2025
9f6db62
wip
crynobone Feb 6, 2025
90de5cf
fix(database): ✏ Fix typo
shaedrich Feb 8, 2025
19f4804
refactor(database): :truck: Rename attribute class
shaedrich Feb 8, 2025
799451a
refactor(database): :white_check_mark: Simplify test
shaedrich Feb 8, 2025
ded61f4
refactor(database): :recycle: Simplify named local scope attribute ch…
shaedrich Feb 8, 2025
ab19b5e
fix(database): :bug: Make attributed named scope statically callable
shaedrich Feb 8, 2025
83a21e4
style(database): :rotating_light: StyleCI
shaedrich Feb 8, 2025
50dbb5a
style(database): :rotating_light: StyleCI
shaedrich Feb 8, 2025
eb4fc57
formatting
taylorotwell Mar 19, 2025
2c44cd5
add files
taylorotwell Mar 19, 2025
1cf779d
fix tests
taylorotwell Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
wip 
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
  • Loading branch information
@crynobone
crynobone committed Feb 6, 2025
commit 6d5aa009d108c78d0eb350b7d777fd37f7aca5b6
2 changes: 1 addition & 1 deletion tests/Integration/Database/EloquentNamedScopedAttibuteTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public function test_it_can_query_named_scoped_from_the_query_builder()

public function test_it_can_query_named_scoped_from_static_query()
{
$query = Fixtures\NamedScopedUser::verifiedUser(true);
$query = Fixtures\NamedScopedUser::verified(true);

$this->assertSame(
'select * from "named_scoped_users" where "email_verified_at" is not null',
Expand Down
Loading