fix(ui): enhance map styling for fullscreen mode to eliminate viewport gaps (#1435)#1439
Conversation
|
@GuthaSrishanthReddy is attempting to deploy a commit to the Elie Team on Vercel. A member of the Team first needs to authorize it. |
koala73
left a comment
There was a problem hiding this comment.
Thanks for tackling this, @GuthaSrishanthReddy! The bottom gap in fullscreen is a real issue. A few things to address before we can merge:
BLOCKING: Duplicate/conflicting selectors
The PR adds display: none !important for .map-bottom-grid and .map-resize-handle, but lines 2488-2491 already hide these with visibility: hidden !important; pointer-events: none !important. Having both is redundant and confusing. Please consolidate to one approach.
HIGH: inset: 0 conflicts with existing top/left/width/height
The base .live-news-fullscreen rule already sets position: fixed; top: 0; left: 0; width: 100vw; height: 100vh. The new rule overrides with inset: 0 !important; width: auto !important; height: auto !important. These two rules fight each other. Better to modify the base rule directly rather than layering overrides.
MEDIUM: Fixed footer over fullscreen map
Pinning .site-footer with position: fixed; z-index: 10002 during fullscreen means it sits permanently on top of the map. The existing pattern hides UI elements during fullscreen for an immersive experience. A persistent footer contradicts that and may obscure map content at the bottom edge (arguably the same gap problem, inverted).
LOW: Trailing newline removed in event-handlers.ts
The only change to this file is removing the final newline. This is a noise diff; most linters expect a trailing newline (POSIX standard). Please revert.
NITPICK: Deleted useful comment
The comment /* Hide map overlays and sibling panels behind fullscreen panel (#829, #859) */ was removed. It references issue numbers and provides context for why those rules exist. Please keep it.
Suggestions:
- Fix the base
.live-news-fullscreenrule directly instead of adding conflicting overrides - Remove the duplicate hiding rules
- Reconsider the fixed footer (hide it during fullscreen, or account for its height)
- Restore the trailing newline in
event-handlers.ts - Keep the issue-referencing comment
Thanks again for the contribution!
6026ebf to
ef876b3
Compare
|
Fixed in the commit ef876b3 (address review feedback)
|
koala73
left a comment
There was a problem hiding this comment.
Thanks for the quick turnaround on the feedback, @GuthaSrishanthReddy! Most of the first-round items are resolved.
A few things still remaining:
BLOCKING: Conflicting .map-container height rules
The existing rule at .live-news-fullscreen .map-container { height: calc(100vh - 80px) !important; } is still in place, while your new rule sets height: auto !important; flex: 1 1 auto !important; on the same element via a more specific selector. This works by specificity, but having two !important height declarations fighting each other is fragile. Please either update the original rule directly or add a comment explaining why both exist (the old one still applies to non-map fullscreen panels like the live news player).
LOW: min-height: 0 missing !important
In the new .map-container rule, min-height: 0 is the only property without !important, while every sibling property uses it. If any inherited style sets min-height with !important, this won't win.
Nice to have: Remove the unrelated blank line deletion (line 161)
The removed blank line after --accent is cosmetic noise. Keeping diffs scoped to the fix makes review easier.
Almost there!
|
Thanks for the review @koala73
|
|
Almost ready to merge! One last tiny thing: line 162 in |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary
Fixes map fullscreen layout so it cleanly fills the viewport without leaving a bottom gap.
The fix is scoped to fullscreen map state and preserves normal layout behavior outside fullscreen.
Type of change
Affected areas
/api/*)Checklist
api/rss-proxy.jsallowlist (if adding feeds) — N/Anpm run typecheck)Screenshots
Before


After
Fixes #1435