Skip to content

Build fixes #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lockbox wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Build fixes #593

lockbox wants to merge 5 commits into from

Conversation

@lockbox
Copy link

@lockbox lockbox commented Jun 2, 2025

This PR does the minimum wrt updating to "modern" build setups.

  • update cmake builds to (successfully) build with modern cmake
  • update c header includes to build with gcc15
  • update rust bindings to be able to build
  • update rust bindings pass clippy lints

Ylarod added a commit to Ylarod/keystone that referenced this pull request Sep 21, 2025
@Ylarod
Merge keystone-engine#593
10b11be 
Squashed commit of the following:

commit 3cd0fbb
Merge: fb92f32 667cce9
Author: Jordan Moore <lockbox.06@protonmail.com>
Date:   Tue Jun 3 05:53:14 2025 +0800

    Merge 667cce9 into fb92f32

commit 667cce9
Author: Jordan Moore <lockbox@struct.foo>
Date:   Mon Jun 2 17:50:50 2025 -0400

    feat: basic CI

commit bf3b00f
Author: Jordan Moore <lockbox@struct.foo>
Date:   Mon Jun 2 17:50:07 2025 -0400

    fix: only attempt to publish bindings on master

commit 4e2fcaa
Author: Jordan Moore <lockbox@struct.foo>
Date:   Mon Jun 2 17:49:30 2025 -0400

    fix: bindings: rust: moderize and format

commit f3f792c
Author: Jordan Moore <lockbox@struct.foo>
Date:   Mon Jun 2 16:58:31 2025 -0400

    fix: build with modern cmake

commit 41197bc
Author: Jordan Moore <lockbox@struct.foo>
Date:   Mon Jun 2 16:36:27 2025 -0400

    fix: cstdint explicitly included when used

    * fixes error in gcc15 where this header is no longer
      implicitly included
@nilathedragon nilathedragon mentioned this pull request Oct 8, 2025
Closed
3 tasks
@Ambossmann Ambossmann mentioned this pull request Oct 9, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lockbox