-
Notifications
You must be signed in to change notification settings - Fork 103
fix: changed links color on blog page to reflect those in docs #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: d-medm <125292555+d-medm@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the blog page’s link styling to align with the brand colors used in the docs, changing default link color and hover behavior.
- Set default link color to match docs (#E67643)
- Updated hover color to a darker shade (#C95919) and removed underline
- Adjusted CSS blocks for
.content a
and.content a:hover
Comments suppressed due to low confidence (2)
components/post-body.module.css:16
- The closing brace is flush-left but previous properties are indented two spaces; align braces and content consistently for readability.
}
color: #E67643; | ||
|
||
} | ||
|
||
.content a:hover { | ||
color: #C95919; |
Copilot
AI
Jun 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider extracting this hex value into a CSS variable (e.g., --link-color) for easier theming and reuse across the site.
color: #E67643; | |
} | |
.content a:hover { | |
color: #C95919; | |
color: var(--link-color); | |
} | |
.content a:hover { | |
color: var(--link-hover-color); |
Copilot uses AI. Check for mistakes.
|
||
.content a:hover { | ||
color: #C95919; | ||
text-decoration: none; |
Copilot
AI
Jun 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the underline on hover may reduce link discoverability. Consider maintaining an underline or adding another focus indicator to meet accessibility best practices.
text-decoration: none; |
Copilot uses AI. Check for mistakes.
Hey @d-medm Thanks for raising this pr, can you please take a look at the copilot review and resove those issues? |
Related Tickets & Documents
Fixes: #2198
Description
Changes
Type of Change
Testing
Demo
Before
After
Environment and Dependencies
Checklist