Skip to content

Conversation

d-medm
Copy link

@d-medm d-medm commented Jun 18, 2025

Related Tickets & Documents

Fixes: #2198

Description

  • Updated blog link colors to match brand colors used in https://keploy.io/docs/
  • Links now appear orange and darker orange on hover

Changes

Type of Change

  • Chore (maintenance, refactoring, tooling updates)
  • Bug fix (non-breaking change that fixes an issue)
  • New feature (change that adds functionality)
  • Breaking Change (may require updates in existing code)
  • UI improvement (visual or design changes)
  • Performance improvement (optimization or efficiency enhancements)
  • Documentation update (changes to README, guides, etc.)
  • CI (updates to continuous integration workflows)
  • Revert (undo a previous commit or merge)

Testing

Demo

Before

screenshot-1750269984441

After

screenshot-1750270001406

Environment and Dependencies

  • New Dependencies:
  • Configuration Changes:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added corresponding tests
  • I have run the build command to ensure there are no build errors
  • My changes have been tested across relevant browsers/devices
  • For UI changes, I've included visual evidence of my changes

Signed-off-by: d-medm <125292555+d-medm@users.noreply.github.com>
@Copilot Copilot AI review requested due to automatic review settings June 18, 2025 19:00
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the blog page’s link styling to align with the brand colors used in the docs, changing default link color and hover behavior.

  • Set default link color to match docs (#E67643)
  • Updated hover color to a darker shade (#C95919) and removed underline
  • Adjusted CSS blocks for .content a and .content a:hover
Comments suppressed due to low confidence (2)

components/post-body.module.css:16

  • The closing brace is flush-left but previous properties are indented two spaces; align braces and content consistently for readability.
}

Comment on lines +14 to +19
color: #E67643;

}

.content a:hover {
color: #C95919;
Copy link

Copilot AI Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider extracting this hex value into a CSS variable (e.g., --link-color) for easier theming and reuse across the site.

Suggested change
color: #E67643;
}
.content a:hover {
color: #C95919;
color: var(--link-color);
}
.content a:hover {
color: var(--link-hover-color);

Copilot uses AI. Check for mistakes.


.content a:hover {
color: #C95919;
text-decoration: none;
Copy link

Copilot AI Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the underline on hover may reduce link discoverability. Consider maintaining an underline or adding another focus indicator to meet accessibility best practices.

Suggested change
text-decoration: none;

Copilot uses AI. Check for mistakes.

@amaan-bhati
Copy link
Member

Hey @d-medm Thanks for raising this pr, can you please take a look at the copilot review and resove those issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants