Improved array literal construction #1097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaszloLango
added
enhancement
|
LGTM |
the property already exists. This improves the performance. JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com
| /* The reference is moved so no need to free stack_top_p[i] except for objects. */ | ||
| if (ecma_is_value_object (stack_top_p[i])) | ||
| { | ||
| ecma_free_value (stack_top_p[i]); |
There was a problem hiding this comment.
Isn't this equivalent to ecma_free_value_if_not_object?
There was a problem hiding this comment.
It is completely the opposite. Free if object.
|
LGTM |
zherczeg
force-pushed
the
optimize_array_literal_creation
branch
from
19c8db5 to
fec6944
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.